bug.h revamp, easier to use

- int types definitions moved to br.h
- bits_implementation() -> print_bitops_impl()
- 64 bitops use ...ll builtins instead of ...l
- add lsb and msb macros
- bit_for_each -> bit_for_each_1 (count from 1)
- bit_for_each_2 -> bit_for_each (count from 0)

.dir-locals.el

@@ -0,0 +1,4 @@
+;; emacs per-directory settings
+((nil . ((compile-command . (concat "make -C "
+                                    (vc-root-dir)
+                                    " -k -j2")))))

.gitignore

@@ -0,0 +1,12 @@
+compile_commands.json
+core
+/.ccls-cache/
+/test/test/
+.lastbuild
+# /test/cutest/
+/tmp/
+# created when building
+/bin/
+/obj/
+/dep/
+/lib/

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "test/cutest"]
+	path = test/cutest
+	url = ../cutest.git

Makefile

@@ -1,6 +1,6 @@
 # brlib Makefile - GNU make only
 #
-# Copyright (C) 2021-2023 Bruno Raoult ("br")
+# Copyright (C) 2021-2024 Bruno Raoult ("br")
 # Licensed under the GNU General Public License v3.0 or later.
 # Some rights reserved. See COPYING.
 #
@@ -10,9 +10,6 @@
 # SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
 #
 
-# important to know where exactly is project root dir
-ROOTDIR   := $(dir $(abspath $(lastword $(MAKEFILE_LIST))))
-
 SHELL     := /bin/bash
 CC        := gcc
 LD        := ld
@@ -41,69 +38,135 @@ DLIB      := $(addsuffix .so, $(LIBDIR)/lib$(LIB))          # dynamic lib
 DEP_FN    := $(SRC_FN) $(LIBSRC_FN)
 DEP       := $(addprefix $(DEPDIR)/,$(DEP_FN:.c=.d))
 
-TESTSRC   := $(wildcard $(TESTDIR)/*.c)
-TEST_FN   := $(notdir $(TESTSRC))
+TEST      := $(wildcard $(TESTDIR)/*.c)
+TEST_FN   := $(notdir $(TEST))
 BIN       := $(addprefix $(BINDIR)/,$(TEST_FN:.c=))
 
-##################################### emacs projectile/ccls dirs & files
-PRJROOT   := .projectile
-EMACSLSP  := .dir-locals.el
-
-CCLSROOT  := .ccls-root
-CCLSFILE  := .ccls
 CCLSCMDS  := compile_commands.json
 
+##################################### Check for compiler and requested build
+BUILDS    := release dev perf debug
+# last compilation build
+BUILDFILE := .lastbuild
+lastbuild := $(file < $(BUILDFILE))
+$(info brlib last:$(lastbuild))
+# default to gcc
+CC        ?= cc
+ifeq ($(CC),cc)
+        CC = gcc
+endif
+
+# if no build specified, use last one
+ifeq ($(build),)
+        build := $(lastbuild)
+endif
+# if build is still undefined, set a default
+ifeq ($(build),)
+        build := release
+endif
+
+$(info brlib build=$(build))
+
+# check for valid build
+ifeq ($(filter $(build),$(BUILDS)),)
+        $(error Error: Unknown build=`$(build)`. Possible builds are: $(BUILDS))
+endif
+
+# if new build, rewrite BUILDFILE
+ifneq ($(build),$(lastbuild))
+        $(info New build:`$(build)` (was:$(lastbuild)))
+        $(file >$(BUILDFILE),$(build))
+endif
 ##################################### pre-processor flags
-CPPFLAGS  := -I$(INCDIR)
-#CPPFLAGS  += -DDEBUG                                       # global
-#CPPFLAGS  += -DDEBUG_DEBUG_C                               # log() funcs debug
-CPPFLAGS  += -DDEBUG_DEBUG                                  # activate logs funcs
-CPPFLAGS  += -DDEBUG_POOL                                   # mem pools
+override CPPFLAGS  += -I $(INCDIR)
+
+ifeq ($(BUILD),release)
+        CPPFLAGS  += -DNDEBUG                               # assert (unused)
+        CPPFLAGS  += -DBUG_ON=0                          CPPFLAGS  += -DWARN_ON=0                 else # ifeq ($(BUILD),dev)
+        #CPPFLAGS  += -DDEBUG                            #CPPFLAGS  += -DDEBUG_DEBUG_C                    CPPFLAGS  += -DDEBUG_DEBUG                       CPPFLAGS  += -DDEBUG_POOL                        CPPFLAGS  += -DBUG_ON=1                          CPPFLAGS  += -DWARN_ON=1                            # warn_on in bug.h
+endif
 
 # remove extraneous spaces (due to spaces before comments)
 CPPFLAGS  := $(strip $(CPPFLAGS))
 
 ##################################### compiler flags
 CFLAGS    := -std=gnu11
-CFLAGS    += -O2
-CFLAGS    += -g
+
 CFLAGS    += -Wall
 CFLAGS    += -Wextra
 CFLAGS    += -march=native
 CFLAGS    += -Wmissing-declarations
 CFLAGS    += -Wno-unused-result
+# TODO: specific to dynamic
 CFLAGS    += -fPIC
-# for gprof
-#CFLAGS    += -pg
-# Next one may be useful for valgrind (some invalid instructions)
-# CFLAGS   += -mno-tbm
+
+### dev OR release
+ifeq ($(BUILD),release)
+        CFLAGS    += -O3
+        CFLAGS    += -funroll-loops
+        CFLAGS    += -flto
+else ifeq ($(BUILD),dev)
+        CFLAGS    += -Og
+        CFLAGS    += -g
+        CFLAGS    += -ginline-points                   # inlined funcs debug info
+        # for gprof
+        #CFLAGS    += -pg
+        # Next one may be useful for valgrind (some invalid instructions)
+        # CFLAGS   += -mno-tbm
+else ifeq ($(BUILD),perf)
+        CFLAGS    += -O3
+        CFLAGS    += -g                                # symbols (gdb, perf, etc.)
+        CFLAGS    += -ginline-points                   # inlined funcs debug info
+        CFLAGS    += -funroll-loops
+else ifeq ($(BUILD),debug)
+        CFLAGS    += -O0
+        CFLAGS    += -g                                # symbols (gdb, perf, etc.)
+        # for gprof
+        #CFLAGS += -pg
+        # Next one may be useful for valgrind (when invalid instructions)
+        #CFLAGS += -mno-tbm
+endif
 
 CFLAGS    := $(strip $(CFLAGS))
 
 ##################################### archiver/linker/dependency flags
 ARFLAGS   := rcs
 LDFLAGS   := -L$(LIBDIR)
+LIBS      := -l$(LIB)
 DEPFLAGS   = -MMD -MP -MF $(DEPDIR)/$*.d
 
-##################################### General targets
-.PHONY: all compile clean cleanall cleanallall
+ifeq ($(BUILD),release)
+        LDFLAGS   += -flto
+endif
 
+##################################### General targets
+.PHONY: all libs lib-static lib-dynamic compile test emacs ccls bear clean \
+        cleanall cleanallall
+
+# default: build libraries
 all: libs
 
-compile: objs
+# libraries
+libs: lib-static lib-dynamic
+lib-static: $(SLIB)
+lib-dynamic: $(DLIB)
 
-test: testbins
+# build objects
+compile: $(OBJ)
 
-clean: cleandep cleanobj cleanlib cleanbin
-
-cleanall: clean cleandepdir cleanobjdir cleanlibdir cleanbindir
-
-cleanallall: cleanall cleanemacs
+# build test binaries
+test: $(BIN)
 
 # setup emacs projectile/ccls
-emacs: emacs-setup
+emacs: $(PRJROOT) $(EMACSLSP)
+
 # update compile-commands.json
-ccls: $(CCLSCMDS)
+ccls bear: $(CCLSCMDS)
+
+# cleanup - need to think about a better system :-)
+clean: cleandep cleanobj cleanlib cleanbin
+cleanall: clean cleandepdir cleanobjdir cleanlibdir cleanbindir
+cleanallall: cleanall cleanemacs
 
 ##################################### cleaning functions
 # rmfiles - deletes a list of files in a directory if they exist.
@@ -172,9 +235,7 @@ cleandepdir:
 	@#[ -d $(DEPDIR) ] && echo cleaning depend files && $(RM) -f $(DEP) || true
 
 ##################################### objects
-.PHONY: objs cleanobj cleanobjdir
-
-objs: $(OBJ)
+.PHONY: cleanobj cleanobjdir
 
 cleanobj:
 	$(call rmfiles,$(OBJ),brlib object)
@@ -182,14 +243,13 @@ cleanobj:
 cleanobjdir:
 	$(call rmdir,$(OBJDIR),brlib objects)
 
-$(OBJDIR)/%.o: $(SRCDIR)/%.c | $(OBJDIR) $(DEPDIR)
+# $(OBJDIR)/%.o: $(BUILDFILE)
+$(OBJDIR)/%.o: $(SRCDIR)/%.c $(BUILDFILE) | $(OBJDIR) $(DEPDIR)
 	@echo compiling $< "->" $@.
 	$(CC) -c $(DEPFLAGS) $(CPPFLAGS) $(CFLAGS) $< -o $@
 
 ##################################### brlib libraries
-.PHONY: libs cleanlib cleanlibdir
-
-libs: $(DLIB) $(SLIB)
+.PHONY: cleanlib cleanlibdir
 
 cleanlib:
 	$(call rmfiles,$(DLIB) $(SLIB),library)
@@ -201,24 +261,26 @@ cleanlibdir:
 $(DLIB): LDFLAGS += -shared
 $(DLIB): $(OBJ) | $(LIBDIR)
 	@echo "building shared library ($@)."
-	$(CC) $(CFLAGS) $(LDFLAGS) $? -o $@
+	@$(CC) $(CFLAGS) $(LDFLAGS) $^ -o $@
 
 $(SLIB): $(OBJ) | $(LIBDIR)
 	@echo "building static library ($@)."
-	$(AR) $(ARFLAGS) $@ $? > /dev/null
+	@$(AR) $(ARFLAGS) $@ $? > /dev/null
 
-##################################### tests
-.PHONY: testbins cleanbin cleanbindir
+##################################### testing
+.PHONY: cleanbin cleanbindir
 
-testbins: $(BIN)
-	echo $^
+CUTESTSRC  := $(TESTDIR)/cutest/CuTest.c
 
 cleanbin:
-	$(call rmfiles,$(TARGET),binary)
+	$(call rmfiles,$(BIN),binary)
 
 cleanbindir:
 	$(call rmdir,$(BINDIR),binaries)
 
+$(BINDIR)/%: $(TESTDIR)/%.c $(SLIB) $(DLIB) | $(BINDIR)
+	$(CC) $(CPPFLAGS) $(CFLAGS) $< $(CUTESTSRC) $(LDFLAGS) $(LIBS) -o $@
+
 ##################################### pre-processed (.i) and assembler (.s) output
 %.i: %.c
 	@echo generating $@
@@ -228,32 +290,22 @@ cleanbindir:
 	@echo generating $@
 	@$(CC) -S -fverbose-asm $(CPPFLAGS) $(CFLAGS) $< -o $@
 
-##################################### Emacs
-.PHONY: emacs-setup cleanemacs
+##################################### Emacs & LSP (ccls)
+.PHONY: cleanemacs cleanccls
 
-emacs-setup: $(PRJROOT) $(EMACSLSP)
+#EMACSLSP   := .dir-locals.el
+CCLSFILES  := .projectile .ccls .ccls-root
+CCLSCACHE  := .ccls-cache
 
 cleanemacs:
-	$(call rmfiles, $(PRJROOT) $(EMACSLSP), Emacs);
+	$(call rmfiles, $(PRJROOT) $(EMACSLSP), Emacs/ccls);
 
-$(PRJROOT) $(EMACSLSP):
-	@if [[ $(@) = $(PRJROOT) ]] ;                           \
-	then                                                    \
-		echo "creating Emacs's projectile root file." ; \
-	else                                                    \
-		echo "creating Emacs's ccls root file." ;       \
-	fi
+$(CCLSFILES):
+	printf "creating Emacs dot-files.\n"
 	@$(TOUCH) $@
 
-##################################### LSP (ccls)
-.PHONY: cleanccls
-
 cleanccls:
-	$(call rmfiles, $(CCLSROOT), ccls);
-
-$(CCLSROOT):
-	echo "creating ccls root file."
-	@$(TOUCH) $@
+	$(call rmfiles, $(CCLSFILES), ccls);
 
 # generate compile_commands.json.
 # TODO: add includes and Makefile dependencies.
@@ -262,11 +314,7 @@ $(CCLSROOT):
 # maybe run cleanobj cleanlibobj in commands ?
 $(CCLSCMDS): cleanobj $(SRC) | $(CCLSROOT)
 	@echo "Generating ccls compile commands file ($@)."
-	@$(BEAR) -- make compile
-
-#.PHONY: bear
-#bear: cleanobj cleanlibobj Makefile | $(CCLSROOT)
-#    @$(BEAR) -- make compile
+	@$(BEAR) -- $(MAKE) test
 
 ##################################### valgrind (mem check)
 .PHONY: memcheck
@@ -293,6 +341,5 @@ showflags:
 	@echo LDFLAGS: $(LDFLAGS)
 
 wtf:
-	@printf "ROOTDIR=+%s+\n\n" "$(ROOTDIR)"
 	@printf "OBJDIR=%s\n\n" "$(OBJDIR)"
 	@printf "OBJ=%s\n\n" "$(OBJ)"

README.org

@@ -0,0 +1,43 @@
+#+title: brlib - A small personal C library
+#+OPTIONS: toc:nil
+#+OPTIONS: num:2
+
+** License
+~SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>~~
+
+This work is, with exceptions below, Copyright (C) 2021-2024 Bruno Raoult
+("br"), and licensed under the GNU General Public License v3.0 or later.
+
+Some rights reserved. See COPYING.
+
+*** The licence exceptions are:*
+
+**** _Cutest testing framework.__
+You can find the original work on [[https://sourceforge.net/projects/cutest/files/cutest/][sourceforge]].
+
+This software is (C) 2000-2003 Asim Jalis, under the zlib License.
+See [[test/cutest/license.txt][license local copy]] or <https://spdx.org/licenses/Zlib.html>.
+
+** Installation:
+*** clone repository
+**** user...
+#+BEGIN_EXAMPLE
+$ git clone https://github.com/braoult/brlib.git
+or
+$ git clone https://git.raoult.com/bruno/brlib.git
+#+END_EXAMPLE
+
+**** OR ...developer
+#+BEGIN_EXAMPLE
+$ git clone git@git.raoult.com:bruno/brlib.git
+$ cd brlib
+$ git remote add github git@github.com:braoult/brlib.git
+$ git fetch --all
+#+END_EXAMPLE
+
+*Add CuTest submodule (optional)*
+#+BEGIN_EXAMPLE
+$ cd brlib
+$ git submodule init
+$ git submodule update
+#+END_EXAMPLE

c/Makefile

@@ -1,59 +0,0 @@
-# Tools Makefile
-#
-# Copyright (C) 2023 Bruno Raoult ("br")
-# Licensed under the GNU General Public License v3.0 or later.
-# Some rights reserved. See COPYING.
-#
-# You should have received a copy of the GNU General Public License along with this
-# program. If not, see <https://www.gnu.org/licenses/gpl-3.0-standalone.html>.
-#
-# SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
-#
-
-SHELL     := /bin/bash
-CC        := gcc
-BEAR      := bear
-
-CFLAGS    += -std=gnu11
-CFLAGS    += -O2
-CFLAGS    += -g
-CFLAGS    += -Wall
-CFLAGS    += -Wextra
-CFLAGS    += -march=native
-CFLAGS    += -Wmissing-declarations
-CFLAGS    += -Wno-unused-result
-# for gprof
-#CFLAGS    += -pg
-# Next one may be useful for valgrind (some invalid instructions)
-#CFLAGS    += -mno-tbm
-
-CPPFLAGS += -DDEBUG_DEBUG		# activate general debug (debug.c)
-CPPFLAGS += -DDEBUG_POOL		# memory pools management
-
-INCDIR    := ./include
-LIBDIR    := ./lib
-OBJDIR    := ./obj
-BRLIBDIR  := ./brlib
-
-LIBNAME   := br_$(shell uname -m)
-#LIB       := lib$(LIBNAME)
-
-
-all: brlib
-
-#export LD_LIBRARY_PATH = $(LIBDIR)
-
-.PHONY: all brlib clean
-
-all: brlib
-
-brlib:
-	$(MAKE) -C $(BRLIBDIR)
-
-bear ccls:
-	@echo building ccls language server compilation database
-	$(MAKE) -C $(BRLIBDIR) ccls
-
-clean:
-	@echo cleaning brlib.
-	@$(MAKE) -C $(BRLIBDIR) clean

c/brlib/include/bits.h

@@ -1,499 +0,0 @@
-/* bits.h - bits functions.
- *
- * Copyright (C) 2021-2022 Bruno Raoult ("br")
- * Licensed under the GNU General Public License v3.0 or later.
- * Some rights reserved. See COPYING.
- *
- * You should have received a copy of the GNU General Public License along with this
- * program. If not, see <https://www.gnu.org/licenses/gpl-3.0-standalone.html>.
- *
- * SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
- *
- */
-#ifndef _BITS_H
-#define _BITS_H
-
-#include <stdint.h>
-#include <stdbool.h>
-#include <bits/wordsize.h>                        /* defines __WORDSIZE: 32 or 64 */
-
-void bits_implementation(void);
-
-#ifndef __has_builtin
-#define __has_builtin(x) 0
-#endif
-
-/* no plan to support 32bits for now...
- * #if __WORDSIZE != 64
- * #error "Only 64 bits word size supported."
- * #endif
- */
-
-/* fixed-size types
- */
-typedef int64_t  s64;
-typedef int32_t  s32;
-typedef int16_t  s16;
-typedef int8_t   s8;
-
-typedef uint64_t u64;
-typedef uint32_t u32;
-typedef uint16_t u16;
-typedef uint8_t  u8;
-
-/* convenience types
- */
-typedef long long int llong;
-typedef unsigned long long int ullong;
-typedef unsigned long int ulong;
-typedef unsigned int uint;
-typedef unsigned short ushort;
-typedef unsigned char uchar;
-/* char is a special case, as it can be signed or unsigned
- */
-typedef signed char schar;
-
-/* define common types sizes
- */
-#define BITS_PER_CHAR 8
-
-#ifndef BITS_PER_SHORT
-#define BITS_PER_SHORT (BITS_PER_CHAR * sizeof (short))
-#endif
-#ifndef BITS_PER_INT
-#define BITS_PER_INT   (BITS_PER_CHAR * sizeof (int))
-#endif
-#ifndef BITS_PER_LONG
-#define BITS_PER_LONG  (BITS_PER_CHAR * sizeof (long))
-#endif
-#ifndef BITS_PER_LLONG
-#define BITS_PER_LLONG (BITS_PER_CHAR * sizeof (long long))
-#endif
-
-/* count set bits:  10101000 -> 3
- *                  ^ ^ ^
- */
-static __always_inline int popcount64(u64 n)
-{
-#   if __has_builtin(__builtin_popcountl)
-    return __builtin_popcountl(n);
-
-#   else
-    int count = 0;
-    while (n) {
-        count++;
-        n &= (n - 1);
-    }
-    return count;
-#   endif
-}
-
-static __always_inline int popcount32(u32 n)
-{
-#   if __has_builtin(__builtin_popcount)
-    return __builtin_popcount(n);
-
-#   else
-    int count = 0;
-    while (n) {
-        count++;
-        n &= (n - 1);
-    }
-    return count;
-#   endif
-}
-
-/* count trailing zeroes : 00101000 -> 3
- *                              ^^^
- */
-static __always_inline int ctz64(u64 n)
-{
-#   if __has_builtin(__builtin_ctzl)
-    return __builtin_ctzl(n);
-
-#   elif __has_builtin(__builtin_clzl)
-    return __WORDSIZE - (__builtin_clzl(n & -n) + 1);
-
-#   else
-    return popcount64((n & -n) - 1);
-#   endif
-}
-
-static __always_inline int ctz32(u32 n)
-{
-#   if __has_builtin(__builtin_ctz)
-    return __builtin_ctzl(n);
-
-#   elif __has_builtin(__builtin_clz)
-    return __WORDSIZE - (__builtin_clz(n & -n) + 1);
-
-#   else
-    return popcount32((n & -n) - 1);
-#   endif
-}
-
-/* clz - count leading zeroes : 00101000 -> 2
- *                              ^^
- */
-static __always_inline int clz64(u64 n)
-{
-#   if __has_builtin(__builtin_clzl)
-    return __builtin_clzl(n);
-
-#   else
-    u64 r, q;
-
-    r = (n > 0xFFFFFFFF) << 5; n >>= r;
-    q = (n > 0xFFFF)     << 4; n >>= q; r |= q;
-    q = (n > 0xFF  )     << 3; n >>= q; r |= q;
-    q = (n > 0xF   )     << 2; n >>= q; r |= q;
-    q = (n > 0x3   )     << 1; n >>= q; r |= q;
-    r |= (n >> 1);
-    return 64 - r - 1;
-#   endif
-}
-
-static __always_inline int clz32(u32 n)
-{
-#   if __has_builtin(__builtin_clz)
-    return __builtin_clz(n);
-
-#   else
-    u32 r, q;
-
-    r = (n > 0xFFFF)     << 4; n >>= r;
-    q = (n > 0xFF  )     << 3; n >>= q; r |= q;
-    q = (n > 0xF   )     << 2; n >>= q; r |= q;
-    q = (n > 0x3   )     << 1; n >>= q; r |= q;
-    r |= (n >> 1);
-    return 32 - r - 1;
-#   endif
-}
-
-/* fls - find last set : 00101000 -> 6
- *                         ^
- */
-static __always_inline int fls64(u64 n)
-{
-    if (!n)
-        return 0;
-    return 64 - clz64(n);
-}
-
-static __always_inline int fls32(u32 n)
-{
-    if (!n)
-        return 0;
-    return 32 - clz32(n);
-}
-
-/* find first set :  00101000 -> 4
- *                       ^
- */
-static __always_inline uint ffs64(u64 n)
-{
-#   if __has_builtin(__builtin_ffsl)
-    return __builtin_ffsl(n);
-
-#   elif __has_builtin(__builtin_ctzl)
-    if (n == 0)
-        return (0);
-    return __builtin_ctzl(n) + 1;
-
-#   else
-    return popcount64(n ^ ~-n);
-#   endif
-}
-
-static __always_inline uint ffs32(u32 n)
-{
-#   if __has_builtin(__builtin_ffs)
-    return __builtin_ffs(n);
-
-#   elif __has_builtin(__builtin_ctz)
-    if (n == 0)
-        return (0);
-    return __builtin_ctz(n) + 1;
-
-#   else
-    return popcount32(n ^ ~-n);
-#   endif
-}
-
-/* rolXX/rorXX are taken from kernel's <linux/bitops.h> are are:
- * SPDX-License-Identifier: GPL-2.0
- */
-
-/**
- * rol64 - rotate a 64-bit value left
- * @word: value to rotate
- * @shift: bits to roll
- */
-static inline u64 rol64(u64 word, unsigned int shift)
-{
-        return (word << (shift & 63)) | (word >> ((-shift) & 63));
-}
-
-/**
- * ror64 - rotate a 64-bit value right
- * @word: value to rotate
- * @shift: bits to roll
- */
-static inline u64 ror64(u64 word, unsigned int shift)
-{
-        return (word >> (shift & 63)) | (word << ((-shift) & 63));
-}
-
-/**
- * rol32 - rotate a 32-bit value left
- * @word: value to rotate
- * @shift: bits to roll
- */
-static inline u32 rol32(u32 word, unsigned int shift)
-{
-        return (word << (shift & 31)) | (word >> ((-shift) & 31));
-}
-
-/**
- * ror32 - rotate a 32-bit value right
- * @word: value to rotate
- * @shift: bits to roll
- */
-static inline u32 ror32(u32 word, unsigned int shift)
-{
-        return (word >> (shift & 31)) | (word << ((-shift) & 31));
-}
-
-/**
- * rol16 - rotate a 16-bit value left
- * @word: value to rotate
- * @shift: bits to roll
- */
-static inline u16 rol16(u16 word, unsigned int shift)
-{
-        return (word << (shift & 15)) | (word >> ((-shift) & 15));
-}
-
-/**
- * ror16 - rotate a 16-bit value right
- * @word: value to rotate
- * @shift: bits to roll
- */
-static inline u16 ror16(u16 word, unsigned int shift)
-{
-        return (word >> (shift & 15)) | (word << ((-shift) & 15));
-}
-
-/**
- * rol8 - rotate an 8-bit value left
- * @word: value to rotate
- * @shift: bits to roll
- */
-static inline u8 rol8(u8 word, unsigned int shift)
-{
-        return (word << (shift & 7)) | (word >> ((-shift) & 7));
-}
-
-/**
- * ror8 - rotate an 8-bit value right
- * @word: value to rotate
- * @shift: bits to roll
- */
-static inline u8 ror8(u8 word, unsigned int shift)
-{
-        return (word >> (shift & 7)) | (word << ((-shift) & 7));
-}
-
-/**
- * __ilog2 - non-constant log of base 2 calculators
- * - the arch may override these in asm/bitops.h if they can be implemented
- *   more efficiently than using fls() and fls64()
- * - the arch is not required to handle n==0 if implementing the fallback
- */
-static __always_inline __attribute__((const))
-int __ilog2_u64(u64 n)
-{
-        return fls64(n) - 1;
-}
-
-static __always_inline __attribute__((const))
-int __ilog2_u32(u32 n)
-{
-        return fls32(n) - 1;
-}
-
-/**
- * is_power_of_2() - check if a value is a power of two
- * @n: the value to check
- *
- * Determine whether some value is a power of two, where zero is
- * *not* considered a power of two.
- * Return: true if @n is a power of 2, otherwise false.
- */
-static inline __attribute__((const))
-bool is_power_of_2(unsigned long n)
-{
-        return (n != 0 && ((n & (n - 1)) == 0));
-}
-
-/**
- * __roundup_pow_of_two() - round up to nearest power of two
- * @n: value to round up
- */
-static inline __attribute__((const))
-u64 __roundup_pow_of_two(u64 n)
-{
-        return 1UL << fls64(n - 1);
-}
-
-/**
- * __rounddown_pow_of_two() - round down to nearest power of two
- * @n: value to round down
- */
-static inline __attribute__((const)) u64 __rounddown_pow_of_two(u64 n)
-{
-        return 1UL << (fls64(n) - 1);
-}
-
-/**
- * ilog2 - log base 2 of 32-bit or a 64-bit unsigned value
- * @n: parameter
- *
- * constant-capable log of base 2 calculation
- * - this can be used to initialise global variables from constant data, hence
- * the massive ternary operator construction
- *
- * selects the appropriately-sized optimised version depending on sizeof(n)
- */
-#define ilog2(n)                        \
-(                                       \
-        __builtin_constant_p(n) ?       \
-        ((n) < 2 ? 0 :                  \
-         63 - __builtin_clzll(n)) :     \
-        (sizeof(n) <= 4) ?              \
-        __ilog2_u32(n) :                \
-        __ilog2_u64(n)                  \
- )
-
-/**
- * roundup_pow_of_two - round the given value up to nearest power of two
- * @n: parameter
- *
- * round the given value up to the nearest power of two
- * - the result is undefined when n == 0
- * - this can be used to initialise global variables from constant data
- */
-#define roundup_pow_of_two(n)                   \
-(                                               \
-        __builtin_constant_p(n) ? (             \
-                ((n) == 1) ? 1 :                \
-                (1UL << (ilog2((n) - 1) + 1))   \
-                                   ) :          \
-        __roundup_pow_of_two(n)                 \
- )
-
-/**
- * rounddown_pow_of_two - round the given value down to nearest power of two
- * @n: parameter
- *
- * round the given value down to the nearest power of two
- * - the result is undefined when n == 0
- * - this can be used to initialise global variables from constant data
- */
-#define rounddown_pow_of_two(n)                 \
-(                                               \
-        __builtin_constant_p(n) ? (             \
-                (1UL << ilog2(n))) :            \
-        __rounddown_pow_of_two(n)               \
- )
-
-static inline __attribute_const__ int __order_base_2(unsigned long n)
-{
-        return n > 1 ? ilog2(n - 1) + 1 : 0;
-}
-
-/**
- * order_base_2 - calculate the (rounded up) base 2 order of the argument
- * @n: parameter
- *
- * The first few values calculated by this routine:
- *  ob2(0) = 0
- *  ob2(1) = 0
- *  ob2(2) = 1
- *  ob2(3) = 2
- *  ob2(4) = 2
- *  ob2(5) = 3
- *  ... and so on.
- */
-#define order_base_2(n)                         \
-(                                               \
-        __builtin_constant_p(n) ? (             \
-            ((n) == 0 || (n) == 1) ?            \
-            0 :                                 \
-            ilog2((n) - 1) + 1) :               \
-        __order_base_2(n)                       \
-)
-
-static inline __attribute__((const)) int __bits_per(unsigned long n)
-{
-        if (n < 2)
-            return 1;
-        if (is_power_of_2(n))
-            return order_base_2(n) + 1;
-        return order_base_2(n);
-}
-
-/**
- * bits_per - calculate the number of bits required for the argument
- * @n: parameter
- *
- * This is constant-capable and can be used for compile time
- * initializations, e.g bitfields.
- *
- * The first few values calculated by this routine:
- * bf(0) = 1
- * bf(1) = 1
- * bf(2) = 2
- * bf(3) = 2
- * bf(4) = 3
- * ... and so on.
- */
-#define bits_per(n)                             \
-(                                               \
-        __builtin_constant_p(n) ? (             \
-            ((n) == 0 || (n) == 1) ?            \
-            1 :                                 \
-            ilog2(n) + 1 :                      \
-            __bits_per(n)                       \
-)
-
-/** bit_for_each - iterate over an u64/u32 bits
- * @pos:        an int used as current bit
- * @tmp:        a temp u64/u32 used as temporary storage
- * @ul:         the u64/u32 to loop over
- *
- * Usage:
- * u64 u=139, _t;     //  u=b10001011
- * int cur;
- * bit_for_each64(cur, _t, u) {
- *     printf("%d\n", cur);
- * }
- * This will display the position of each bit set in ul: 1, 2, 4, 8
- *
- * I should probably re-think the implementation...
- */
-#define bit_for_each64(pos, tmp, ul)                                    \
-    for (tmp = ul, pos = ffs64(tmp); tmp; tmp &= (tmp - 1),  pos = ffs64(tmp))
-
-#define bit_for_each32(pos, tmp, ul)                                    \
-    for (tmp = ul, pos = ffs32(tmp); tmp; tmp &= (tmp - 1),  pos = ffs32(tmp))
-
-/** or would it be more useful (counting bits from zero instead of 1) ?
- */
-#define bit_for_each64_2(pos, tmp, ul)                                  \
-    for (tmp = ul, pos = ctz64(tmp); tmp; tmp ^= 1UL << pos, pos = ctz64(tmp))
-
-#define bit_for_each32_2(pos, tmp, ul)                                  \
-    for (tmp = ul, pos = ctz32(tmp); tmp; tmp ^= 1U << pos, pos = ctz32(tmp))
-
-#endif  /* _BITS_H */

c/brlib/include/bug.h

@@ -1,71 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _BR_BUG_H
-#define _BR_BUG_H
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <stdarg.h>
-#include "likely.h"
-#include "debug.h"
-
-/* BUG functions inspired by Linux kernel's <asm/bug.h>
- */
-
-#define panic() exit(0xff)
-
-/*
- * Don't use BUG() or BUG_ON() unless there's really no way out; one
- * example might be detecting data structure corruption in the middle
- * of an operation that can't be backed out of.  If the (sub)system
- * can somehow continue operating, perhaps with reduced functionality,
- * it's probably not BUG-worthy.
- *
- * If you're tempted to BUG(), think again:  is completely giving up
- * really the *only* solution?  There are usually better options, where
- * users don't need to reboot ASAP and can mostly shut down cleanly.
- */
-#define BUG() do {                                                                      \
-        fprintf(stderr, "BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __func__); \
-        panic();                                                                        \
-    } while (0)
-
-#define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
-
-/*
- * WARN(), WARN_ON(), WARN_ON_ONCE, and so on can be used to report
- * significant kernel issues that need prompt attention if they should ever
- * appear at runtime.
- *
- * Do not use these macros when checking for invalid external inputs
- * (e.g. invalid system call arguments, or invalid data coming from
- * network/devices), and on transient conditions like ENOMEM or EAGAIN.
- * These macros should be used for recoverable kernel issues only.
- * For invalid external inputs, transient conditions, etc use
- * pr_err[_once/_ratelimited]() followed by dump_stack(), if necessary.
- * Do not include "BUG"/"WARNING" in format strings manually to make these
- * conditions distinguishable from kernel issues.
- *
- * Use the versions with printk format strings to provide better diagnostics.
- */
-#define __WARN() do {                                                      \
-        fprintf(stderr, "WARNING: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __func__); \
-    } while (0)
-#define __WARN_printf(arg...) do {              \
-        vfprintf(stderr, arg);                  \
-    } while (0)
-
-#define WARN_ON(condition) ({                   \
-            int __ret_warn_on = !!(condition);  \
-            if (unlikely(__ret_warn_on))        \
-		__WARN();                       \
-            unlikely(__ret_warn_on);            \
-        })
-
-#define WARN(condition, format...) ({           \
-            int __ret_warn_on = !!(condition);  \
-            if (unlikely(__ret_warn_on))        \
-		__WARN_printf(format);          \
-            unlikely(__ret_warn_on);            \
-        })
-
-#endif /* _BR_BUG_H */

include/bitops-emulated/generic-bswap.h

@@ -0,0 +1,38 @@
+/* generic-bswap.h - generic bswap implementations.
+ *
+ * Copyright (C) 2024 Bruno Raoult ("br")
+ * Licensed under the GNU General Public License v3.0 or later.
+ * Some rights reserved. See COPYING.
+ *
+ * You should have received a copy of the GNU General Public License along with this
+ * program. If not, see <https://www.gnu.org/licenses/gpl-3.0-standalone.html>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
+ *
+ */
+#ifndef _GENERIC_BSWAP_H_
+#define _GENERIC_BSWAP_H_
+
+#include "brlib.h"
+
+/* Adapted from: http://www-graphics.stanford.edu/%7Eseander/bithacks.html
+ */
+static __always_inline u32 __bswap32_emulated(u32 n)
+{
+   const u32 k = 0x00FF00FF;
+   n = ((n >>  8) & k) | ((n & k) <<  8);
+   n = ( n >> 16)      | ( n      << 16);
+   return n;
+}
+
+static __always_inline u64 __bswap64_emulated(u64 n)
+{
+   const u64 k1 = 0x00FF00FF00FF00FFull;
+   const u64 k2 = 0x0000FFFF0000FFFFull;
+   n = ((n >>  8) & k1) | ((n & k1) <<  8);
+   n = ((n >> 16) & k2) | ((n & k2) << 16);
+   n = ( n >> 32)       | ( n       << 32);
+   return n;
+}
+
+#endif  /* _GENERIC_BSWAP_H_ */

include/bitops-emulated/generic-clz.h

@@ -0,0 +1,45 @@
+/* generic-clz.h - generic clz implementations.
+ *
+ * Copyright (C) 2024 Bruno Raoult ("br")
+ * Licensed under the GNU General Public License v3.0 or later.
+ * Some rights reserved. See COPYING.
+ *
+ * You should have received a copy of the GNU General Public License along with this
+ * program. If not, see <https://www.gnu.org/licenses/gpl-3.0-standalone.html>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
+ *
+ */
+#ifndef _GENERIC_CLZ_H_
+#define _GENERIC_CLZ_H_
+
+#include "brlib.h"
+
+/* Adapted from: http://www-graphics.stanford.edu/%7Eseander/bithacks.html
+ */
+static __always_inline int __clz32_emulated(u32 n)
+{
+    uint r, q;
+
+    r  = (n > 0xFFFF) << 4; n >>= r;
+    q  = (n > 0xFF  ) << 3; n >>= q; r |= q;
+    q  = (n > 0xF   ) << 2; n >>= q; r |= q;
+    q  = (n > 0x3   ) << 1; n >>= q; r |= q;
+    r |= (n >> 1);
+    return 31 - r;
+}
+
+static __always_inline int __clz64_emulated(u64 n)
+{
+    uint r, q;
+
+    r = (n > 0xFFFFFFFF) << 5; n >>= r;
+    q = (n > 0xFFFF)     << 4; n >>= q; r |= q;
+    q = (n > 0xFF  )     << 3; n >>= q; r |= q;
+    q = (n > 0xF   )     << 2; n >>= q; r |= q;
+    q = (n > 0x3   )     << 1; n >>= q; r |= q;
+    r |= (n >> 1);
+    return 63 - r;
+}
+
+#endif  /* _GENERIC_CLZ_H_ */

include/bitops-emulated/generic-ctz.h

@@ -0,0 +1,130 @@
+/* generic-ctz.h - generic ctz implementations.
+ *
+ * Copyright (C) 2024 Bruno Raoult ("br")
+ * Licensed under the GNU General Public License v3.0 or later.
+ * Some rights reserved. See COPYING.
+ *
+ * You should have received a copy of the GNU General Public License along with this
+ * program. If not, see <https://www.gnu.org/licenses/gpl-3.0-standalone.html>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
+ *
+ */
+#ifndef _GENERIC_CTZ_H_
+#define _GENERIC_CTZ_H_
+
+#include "brlib.h"
+
+/* Adapted from: http://www-graphics.stanford.edu/%7Eseander/bithacks.html
+ */
+static __always_inline int __ctz32_emulated(u32 n)
+{
+    int r = 0;
+    if (!(n & 0xffff)) {
+        n >>= 16;
+        r += 16;
+    }
+    if (!(n & 0xff)) {
+        n >>= 8;
+        r += 8;
+    }
+    if (!(n & 0xf)) {
+        n >>= 4;
+        r += 4;
+    }
+    if (!(n & 3)) {
+        n >>= 2;
+        r += 2;
+    }
+    if (!(n & 1)) {
+        n >>= 1;
+        r += 1;
+    }
+    return r;
+}
+
+#define __ctz32_emulated2(n) ({   \
+    int r = 0;                    \
+    if (!(n & 0xffff)) {          \
+        n >>= 16;                 \
+        r += 16;                  \
+    }                             \
+    if (!(n & 0xff)) {            \
+        n >>= 8;                  \
+        r += 8;                   \
+    }                             \
+    if (!(n & 0xf)) {             \
+        n >>= 4;                  \
+        r += 4;                   \
+    }                             \
+    if (!(n & 3)) {               \
+        n >>= 2;                  \
+        r += 2;                   \
+    }                             \
+    if (!(n & 1)) {               \
+        n >>= 1;                  \
+        r += 1;                   \
+    }                             \
+    r;                            \
+})
+
+static __always_inline int __ctz64_emulated(u64 n)
+{
+    int r = 0;                                    /* !!!!!!!!!!!!!!!!!!!!!!!! */
+    if (!(n & 0xffffffff)) {
+        n >>= 32;
+        r += 32;
+    }
+    if (!(n & 0xffff)) {
+        n >>= 16;
+        r += 16;
+    }
+    if (!(n & 0xff)) {
+        n >>= 8;
+        r += 8;
+    }
+    if (!(n & 0xf)) {
+        n >>= 4;
+        r += 4;
+    }
+    if (!(n & 3)) {
+        n >>= 2;
+        r += 2;
+    }
+    if (!(n & 1)) {
+        n >>= 1;
+        r += 1;
+    }
+    return r;
+}
+
+#define __ctz64_emulated2(n) ({   \
+    int r = 0;                  \
+    if (!(n & 0xffffffff)) {      \
+        n >>= 32;                 \
+        r += 32;                  \
+    }                             \
+    if (!(n & 0xffff)) {          \
+        n >>= 16;                 \
+        r += 16;                  \
+    }                             \
+    if (!(n & 0xff)) {            \
+        n >>= 8;                  \
+        r += 8;                   \
+    }                             \
+    if (!(n & 0xf)) {             \
+        n >>= 4;                  \
+        r += 4;                   \
+    }                             \
+    if (!(n & 3)) {               \
+        n >>= 2;                  \
+        r += 2;                   \
+    }                             \
+    if (!(n & 1)) {               \
+        n >>= 1;                  \
+        r += 1;                   \
+    }                             \
+    r;                            \
+})
+
+#endif  /* _GENERIC_CTZ_H_ */

include/bitops-emulated/generic-ilog2.h

@@ -0,0 +1,60 @@
+/* generic-ilog2.h - generic ilog2 implementations.
+ *
+ * Copyright (C) 2024 Bruno Raoult ("br")
+ * Licensed under the GNU General Public License v3.0 or later.
+ * Some rights reserved. See COPYING.
+ *
+ * You should have received a copy of the GNU General Public License along with this
+ * program. If not, see <https://www.gnu.org/licenses/gpl-3.0-standalone.html>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
+ *
+ */
+#ifndef _GENERIC_ILOG2_H_
+#define _GENERIC_ILOG2_H_
+
+#include "brlib.h"
+
+/*
+ * See https://stackoverflow.com/a/11398748/3079831
+ */
+static const int __ilog2_32_table[32] = {
+    0,  9,  1, 10, 13, 21,  2, 29,
+    11, 14, 16, 18, 22, 25,  3, 30,
+    8, 12, 20, 28, 15, 17, 24,  7,
+    19, 27, 23,  6, 26,  5,  4, 31
+};
+
+static const int __ilog2_64_table[64] = {
+    63,  0, 58,  1, 59, 47, 53,  2,
+    60, 39, 48, 27, 54, 33, 42,  3,
+    61, 51, 37, 40, 49, 18, 28, 20,
+    55, 30, 34, 11, 43, 14, 22,  4,
+    62, 57, 46, 52, 38, 26, 32, 41,
+    50, 36, 17, 19, 29, 10, 13, 21,
+    56, 45, 25, 31, 35, 16,  9, 12,
+    44, 24, 15,  8, 23,  7,  6,  5
+};
+
+static __always_inline __const int __ilog2_32_emulated (u32 n)
+{
+    n |= n >> 1;
+    n |= n >> 2;
+    n |= n >> 4;
+    n |= n >> 8;
+    n |= n >> 16;
+    return __ilog2_32_table[(n*0x07C4ACDD) >> 27];
+}
+
+static __always_inline __const int __ilog2_64_emulated (u64 n)
+{
+    n |= n >> 1;
+    n |= n >> 2;
+    n |= n >> 4;
+    n |= n >> 8;
+    n |= n >> 16;
+    n |= n >> 32;
+    return __ilog2_64_table[((n - (n >> 1))*0x07EDD5E59A4E28C2LL) >> 58];
+}
+
+#endif /* _GENERIC_ILOG2_H_ */

include/bitops.h

@@ -0,0 +1,281 @@
+/* bitops.h - bits functions.
+ *
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
+ * Licensed under the GNU General Public License v3.0 or later.
+ * Some rights reserved. See COPYING.
+ *
+ * You should have received a copy of the GNU General Public License along with this
+ * program. If not, see <https://www.gnu.org/licenses/gpl-3.0-standalone.html>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
+ *
+ */
+#ifndef _BITS_H
+#define _BITS_H
+
+#include "brlib.h"
+#include "bitops-emulated/generic-ctz.h"
+#include "bitops-emulated/generic-clz.h"
+#include "bitops-emulated/generic-bswap.h"
+
+#ifndef __has_builtin
+#define __has_builtin(x) 0
+#endif
+
+/* determine which native builtins are available
+ */
+#if __has_builtin(__builtin_popcount)
+#   define HAS_POPCOUNT
+#endif
+#if __has_builtin(__builtin_ctz)
+#   define HAS_CTZ
+#endif
+#if __has_builtin(__builtin_clz)
+#   define HAS_CLZ
+#endif
+#if __has_builtin(__builtin_ffs)
+#   define HAS_FFS
+#endif
+#if __has_builtin(__builtin_bswap32)
+#   define HAS_BSWAP
+#endif
+
+/**
+ * print_bitops_impl() - print bitops implementation.
+ *
+ * For basic bitops (popcount, ctz, etc...), print the implementation
+ * (builtin, emulated, ...).
+ */
+void print_bitops_impl(void);
+
+/* no plan to support 32bits for now...
+ * #if __WORDSIZE != 64
+ * #error "Only 64 bits word size supported."
+ * #endif
+ */
+
+/**
+ * lsb, msb: 0-indexed least/most significant bit: 10101000
+ *                                         msb = 7 ^   ^ lsb = 3
+ *
+ */
+#define lsb64(x) (ctz64(x))
+#define lsb32(x) (ctz32(x))
+#define msb64(x) (63 ^ clz64(x))
+#define msb32(x) (31 ^ clz32(x))
+
+/**
+ * popcount32, popcout64 - count set bits:  10101000 -> 3
+ * @n: unsigned 32 or 64 bits integer.
+ *
+ */
+#if defined(HAS_POPCOUNT)
+#   define __popcount32_native(n) __builtin_popcount(n)
+#   define __popcount64_native(n) __builtin_popcountll(n)
+
+#   define popcount64(n) __popcount64_native(n)
+#   define popcount32(n) __popcount32_native(n)
+
+/* see ctz section below */
+#   define __ctz32_popcount(n) (popcount(n & -n) - 1)
+#   define __ctz64_popcount(n) (popcountll(n & -n) - 1)
+
+/* see ffs section below */
+#   define __ffs32_popcount(n) (__builtin_popcount((n) ^ ~-(n)))
+#   define __ffs64_popcount(n) (__builtin_popcountll((n) ^ ~-(n)))
+
+#endif
+/* Brian Kernighan's algorithm - pretty efficient for likely sparse values
+ */
+#define __popcount_emulated(n)  ({      \
+    int ___count = 0;                   \
+    while (n) {                         \
+        ___count++;                     \
+        n &= (n - 1);                   \
+    }                                   \
+    ___count; })
+#if !defined(popcount32)
+#   define popcount32(n) __popcount_emulated(n)
+#endif
+#if !defined(popcount64)
+#   define popcount64(n) __popcount_emulated(n)
+#endif
+
+/**
+ * ctz32, ctz64 - count trailing zeros: 00101000 -> 3
+ * @n: unsigned 32 or 64 bits integer.
+ *
+ * Not defined if no bit set, so check for non-zero before calling this.
+ * This is similat the FFS (First Find Set), which has FFS(0) = 0.
+ */
+#if defined(HAS_CTZ)
+#   define __ctz32_native(n)  __builtin_ctz(n)
+#   define __ctz64_native(n)  __builtin_ctzll(n)
+#   define ctz32(n) __ctz32_native(n)
+#   define ctz64(n) __ctz64_native(n)
+
+/* see ffs section below */
+#   define __ffs32_ctz(n) ({ n? __builtin_ctz(n) + 1: 0; })
+#   define __ffs64_ctz(n) ({ n? __builtin_ctzll(n) + 1: 0; })
+#endif
+#if !defined(ctz32) && defined(__ctz32_popcount)
+#   define ctz32(n) __ctz32_popcount(n)
+#   define ctz64(n) __ctz64_popcount(n)
+#endif
+#if !defined(ctz32)
+#   define ctz32(n) __ctz32_emulated(n)
+#   define ctz64(n) __ctz64_emulated(n)
+#endif
+
+/**
+ * clz32, clz64 - count leading zeros: 00101000 -> 2
+ *
+ * @n: unsigned 32 or 64 bits integer.
+ *
+ * Not defined if no bit set, so check for non-zero before calling this.
+ */
+#if defined (HAS_CLZ)
+#   define __clz32_native(n)  __builtin_clz(n)
+#   define __clz64_native(n)  __builtin_clzll(n)
+#   define clz32(n) __clz32_native(n)
+#   define clz64(n) __clz64_native(n)
+#endif
+#if !defined(clz32)
+#   define clz32(n) __clz32_emulated(n)
+#   define clz64(n) __clz64_emulated(n)
+#endif
+
+/**
+ * ffs32, ffs64 - find first bit set, indexed from 0: 00101000 -> 4
+ * ffz32, ffz64 - find first bit unset, indexed from 0: 00101010 -> 2
+ * @n: unsigned 32 or 64 bits integer.
+ *
+ * ffs(n) is similar to ctz(n) + 1, but returns 0 if n == 0 (except
+ * for ctz version, where ffs(0) is undefined).
+ * ffz(n) is ffz(~n), with undefine value if n = 0.
+ */
+#if defined(HAS_FFS)
+#   define __ffs32_native(n)  __builtin_ffs(n)
+#   define __ffs64_native(n)  __builtin_ffsll(n)
+#   define ffs32(n) __ffs32_native(n)
+#   define ffs64(n) __ffs64_native(n)
+#endif
+#define __ffs32_emulated(n) (popcount32((n) ^ ~-(n)))
+#define __ffs64_emulated(n) (popcount64((n) ^ ~-(n)))
+#if !defined(ffs32) && defined(__ffs32_popcount)
+#   define ffs32(n) __ffs32_popcount(n)
+#   define ffs64(n) __ffs64_popcount(n)
+#endif
+#if !defined(ffs32) && defined(__ffs32_ctz)
+#   define ffs32(n) __ffs32_ctz(n)
+#   define ffs64(n) __ffs64_ctzll(n)
+#endif
+#if !defined(ffs32)
+#   define ffs32(n) __ffs32_emulated(n)
+#   define ffs64(n) __ffs64_emulated(n)
+#endif
+#define ffz32(n)  ffs32(~(n))
+#define ffz64(n)  ffs64(~(n))
+
+/**
+ * bswap32, bswap64 - reverse bytes: 0x01020304 -> 0x04030201
+ * @n: unsigned 32 or 64 bits integer.
+ *
+ * ffs(n) is similar to ctz(n) + 1, but returns 0 if n == 0 (except
+ * for ctz version, where ffs(0) is undefined).
+ * ffz(n) is ffz(~n), with undefine value if n = 0.
+ */
+#if defined(HAS_BSWAP)
+#   define __bswap32_native(n)  __builtin_bswap32(n)
+#   define __bswap64_native(n)  __builtin_bswap64(n)
+#   define bswap32(n) __bswap32_native(n)
+#   define bswap64(n) __bswap64_native(n)
+#else
+#   define bswap32(n) __bswap32_emulated(n)
+#   define bswap64(n) __bswap64_emulated(n)
+#endif
+
+/**
+ * fls32, fls64 - return one plus MSB index: 00101000 -> 6
+ * @n: unsigned 32 or 64 bits integer.
+ *
+ * Similar to nbits(n) - clz(n), but returns 0 if n == 0;
+ */
+#define fls32(n) ((n)? 32 - clz32(n): 0)
+#define fls64(n) ((n)? 64 - clz64(n): 0)
+
+/*
+ * rol32, rot64 - rotate left
+ * @num: unsigned 8, 16, 32 or 64 bits integer
+ * @n: bits to roll
+ * See: https://stackoverflow.com/a/31488147/3079831
+ */
+#define rol8(num, n)  ((num << (n &  7)) | (num >> ((-n) &  7)))
+#define rol16(num, n) ((num << (n & 15)) | (num >> ((-n) & 15)))
+#define rol32(num, n) ((num << (n & 31)) | (num >> ((-n) & 31)))
+#define rol64(num, n) ((num << (n & 63)) | (num >> ((-n) & 63)))
+
+/**
+ * ror8, ror16, ror32, ror64 - rotate right
+ * @num: unsigned 8, 16, 32 or 64 bits integer
+ * @n: bits to roll
+ */
+#define ror8(num, n)  ((num >> (n &  7)) | (num << ((-n) &  7)))
+#define ror16(num, n) ((num >> (n & 15)) | (num << ((-n) & 15)))
+#define ror32(num, n) ((num >> (n & 31)) | (num << ((-n) & 31)))
+#define ror64(num, n) ((num >> (n & 63)) | (num << ((-n) & 63)))
+
+/**
+ * ilog2_32, ilog2_64 - log base 2
+ * @n: unsigned 32 or 64 bits integer.
+ *
+ * Undefine value if n = 0.
+ */
+#define ilog2_32(n) (msb32(n))
+#define ilog2_64(n) (msb64(n))
+
+/**
+ * is_pow2() - check if number is a power of two
+ * @n: the value to check
+ *
+ * Zero is *not* considered a power of two.
+ */
+#define is_pow2(n) (n != 0 && (((n) & ((n) - 1)) == 0))
+
+/**
+ * bit_for_eachXX - iterate over an integer bits (0-indexed)
+ * bit_for_eachXX_ffs - iterate over an integer bits (1-indexed)
+ * @pos:  int used as current bit
+ * @tmp:  temp u64/u32 used as temporary storage
+ * @u:    u32/u64 to loop over
+ *
+ * Bits are 0-indexed from 0 with bit_for_each, and 1-indexed with
+ * bits_for_each_ffs.
+ *
+ * Example:
+ * u64 u=139, _t;           // u=b10001011
+ * int cur;
+ * bit_for_each64(cur, _t, u) {
+ *     printf("%d\n", cur);
+ * }
+ * This will display the position of each bit set in ul: 0, 1, 3, 7
+ *
+ */
+#define bit_for_each32(pos, tmp, u)                  \
+    for (tmp = u, pos = ctz32(tmp);                  \
+         tmp;                                        \
+         tmp ^= 1U << pos, pos = ctz32(tmp))
+#define bit_for_each64(pos, tmp, ul)                 \
+    for (tmp = ul, pos = ctz64(tmp);                 \
+         tmp;                                        \
+         tmp ^= 1UL << pos, pos = ctz64(tmp))
+#define bit_for_each64_ffs(pos, tmp, u)              \
+    for (tmp = u, pos = ffs64(tmp);                  \
+         tmp;                                        \
+         tmp &= (tmp - 1),  pos = ffs64(tmp))
+#define bit_for_each32_ffs(pos, tmp, ul)             \
+    for (tmp = ul, pos = ffs32(tmp);                 \
+         tmp;                                        \
+         tmp &= (tmp - 1),  pos = ffs32(tmp))
+
+#endif  /* _BITS_H */

include/brlib.h

@@ -1,6 +1,6 @@
-/* br.h - misc macros.
+/* brlib.h - misc types/macros.
  *
- * Copyright (C) 2021-2022 Bruno Raoult ("br")
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
  * Licensed under the GNU General Public License v3.0 or later.
  * Some rights reserved. See COPYING.
  *
@@ -15,11 +15,57 @@
  * This header contains generic stuff.
  */
 
-#ifndef _BR_H
-#define _BR_H
+#ifndef _BRLIB_H
+#define _BRLIB_H
+
+#include <stdlib.h>
+#include <stdint.h>
+#include <stdbool.h>
+#include <bits/wordsize.h>                        /* defines __WORDSIZE: 32 or 64 */
 
 #include "struct-group.h"
 
+/* fixed-size types
+ */
+typedef int64_t  s64;
+typedef int32_t  s32;
+typedef int16_t  s16;
+typedef int8_t   s8;
+
+typedef uint64_t u64;
+typedef uint32_t u32;
+typedef uint16_t u16;
+typedef uint8_t  u8;
+
+/* convenience types
+ */
+typedef long long          llong;
+typedef unsigned long long ullong;
+typedef unsigned long int  ulong;
+typedef unsigned int       uint;
+typedef unsigned short     ushort;
+typedef unsigned char      uchar;
+/* char is a special case, as it can be signed or unsigned
+ */
+typedef signed char schar;
+
+/* define common types sizes
+ */
+#define BITS_PER_CHAR 8
+
+#ifndef BITS_PER_SHORT
+#define BITS_PER_SHORT (BITS_PER_CHAR * sizeof (short))
+#endif
+#ifndef BITS_PER_INT
+#define BITS_PER_INT   (BITS_PER_CHAR * sizeof (int))
+#endif
+#ifndef BITS_PER_LONG
+#define BITS_PER_LONG  (BITS_PER_CHAR * sizeof (long))
+#endif
+#ifndef BITS_PER_LLONG
+#define BITS_PER_LLONG (BITS_PER_CHAR * sizeof (long long))
+#endif
+
 /* Indirect stringification.  Doing two levels allows the parameter to be a
  * macro itself.  For example, compile with -DFOO=bar, __stringify(FOO)
  * converts to "bar".
@@ -43,6 +89,7 @@
  */
 #define __unused             __attribute__((__unused__))
 #define __used               __attribute__((__used__))
+#define __const              __attribute__((__const__))
 
 /* see https://lkml.org/lkml/2018/3/20/845 for explanation of this monster
  */
@@ -221,4 +268,4 @@
 	({ signed type __x = (x); __x < 0 ? -__x : __x; }), other)
 
 
-#endif  /* _BR_H */
+#endif  /* _BRLIB_H */

include/bug.h

@@ -0,0 +1,61 @@
+/* bug.h - bug_on/warn_on/warn functions.
+ *
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
+ * Licensed under the GNU General Public License v3.0 or later.
+ * Some rights reserved. See COPYING.
+ *
+ * You should have received a copy of the GNU General Public License along with this
+ * program. If not, see <https://www.gnu.org/licenses/gpl-3.0-standalone.html>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
+ *
+ */
+
+#ifndef BUG_H
+#define BUG_H
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <stdbool.h>
+#include <stdarg.h>
+
+#define bug_on_always(expr) do {                                      \
+        if (expr) {                                                   \
+            fprintf(stderr,                                           \
+                    "** BUG ON %s[%s:%d]: assertion '%s' failed.\n",  \
+                    __func__, __FILE__,__LINE__, #expr);                    \
+            abort();                                                  \
+            /* not reached */                                         \
+        }                                                             \
+    } while (0)
+
+#define warn(expr, args...) ({                                        \
+        int _ret = !!(expr);                                          \
+        if (_ret)                                                     \
+            fprintf(stderr, ##args);                                  \
+        _ret;                                                         \
+    })
+
+#define warn_on_always(expr) ({                                       \
+            warn(expr,                                                \
+                 "** WARN ON %s[%s:%d]: assertion '%s' failed.\n",    \
+                 __func__, __FILE__,__LINE__, #expr);                       \
+        })
+
+#ifdef BUG_ON
+
+#define bug_on(expr)          bug_on_always(expr)
+
+#define warn_on(expr)         warn_on_always(expr)
+#define warn_on_or_eval(expr) warn_on(expr)
+
+#else
+
+#define bug_on(expr)
+
+#define warn_on(expr)
+#define warn_on_or_eval(expr) (expr)
+
+#endif  /* BUG_ON */
+
+#endif /* BUG_H */

include/debug.h

@@ -1,6 +1,6 @@
 /* debug.h - debug/log management.
  *
- * Copyright (C) 2021-2023 Bruno Raoult ("br")
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
  * Licensed under the GNU General Public License v3.0 or later.
  * Some rights reserved. See COPYING.
  *
@@ -16,9 +16,8 @@
 
 #include <stdio.h>
 #include <stdbool.h>
-#include <stdint.h>
 
-#include <br.h>
+#include "brlib.h"
 
 #define NANOSEC  1000000000                       /* nano sec in sec */
 #define MILLISEC 1000000                          /* milli sec in sec */
@@ -27,12 +26,64 @@
 
 #ifdef DEBUG_DEBUG
 
-void debug_init(int level, FILE *stream, bool flush);
+/**
+ * debug_level_set - get debug level.
+ * @level: integer debug level.
+ *
+ * @Return: void.
+ */
 void debug_level_set(int level);
+
+/**
+ * debug_level_get - get debug level.
+ *
+ * @Return: current level debug (integer).
+ */
 int debug_level_get(void);
+
+/**
+ * debug_stream_set - set debug output stream.
+ * @stream: (FILE *) output stream
+ *
+ * @Return: void.
+ */
 void debug_stream_set(FILE *stream);
-long long debug_timer_elapsed(void);
+
+/**
+ * debug_flush_set - set debug flush option.
+ * @flush: boolean, if true, flush after each output.
+ *
+ * @Return: void.
+ */
 void debug_flush_set(bool flush);
+
+/**
+ * debug_init - init debug module.
+ * @level: debug level (integer).
+ * @stream: (FILE *) output stream
+ * @flush: boolean, if true, flush after each output.
+ *
+ * @Return: void.
+ */
+void debug_init(int level, FILE *stream, bool flush);
+
+/**
+ * debug_timer_elapsed - get current elapsed debug timer value.
+ *
+ * @Return: long long, timer elapsed.
+ */
+long long debug_timer_elapsed(void);
+
+/**
+ * debug - log function.
+ * @level: log level
+ * @timestamp: boolean, print timestamp if true
+ * @indent: indent level (2 spaces each)
+ * @src: source file/func name (or NULL)
+ * @line: line number
+ *
+ * @Return: void.
+ */
 void _printf debug(int level, bool timestamp,
                    int indent, const char *src,
                    int line, const char *fmt, ...);

include/hash.h

@@ -9,8 +9,9 @@
    (C) 2002 Nadia Yvette Chambers, IBM */
 
 #include <asm/bitsperlong.h>
-#include "bits.h"
-#include "br.h"
+
+#include "brlib.h"
+#include "bitops.h"
 
 /*
  * The "GOLDEN_RATIO_PRIME" is used in ifs/btrfs/brtfs_inode.h and

include/list_sort.h

@@ -7,8 +7,6 @@
 #ifndef _BR_LIST_SORT_H
 #define _BR_LIST_SORT_H
 
-//#include <linux/types.h>
-
 struct list_head;
 
 typedef int __attribute__((nonnull(2,3))) (*list_cmp_func_t)(void *,

include/pjwhash-inline.h

@@ -1,6 +1,6 @@
 /* pjwhash-inline.h - PJW hash function, inline version.
  *
- * Copyright (C) 2021-2022 Bruno Raoult ("br")
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
  * Licensed under the GNU General Public License v3.0 or later.
  * Some rights reserved. See COPYING.
  *
@@ -14,7 +14,7 @@
 #ifndef _PJWHASH_INLINE_H
 #define _PJWHASH_INLINE_H
 
-#include "bits.h"
+#include "brlib.h"
 
 #define THREE_QUARTERS ((int) ((BITS_PER_INT * 3) / 4))
 #define ONE_EIGHTH     ((int) (BITS_PER_INT / 8))

include/pjwhash.h

@@ -1,6 +1,6 @@
 /* pjwhash.h - PJW hash function, extern version.
  *
- * Copyright (C) 2021-2022 Bruno Raoult ("br")
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
  * Licensed under the GNU General Public License v3.0 or later.
  * Some rights reserved. See COPYING.
  *
@@ -13,7 +13,7 @@
 #ifndef _PJWHASH_H
 #define _PJWHASH_H
 
-#include "bits.h"
+#include "brlib.h"
 
 /**
  * unsigned int pjwhash - PJW hash function

include/plist.h

@@ -279,7 +279,7 @@ static inline int plist_node_empty(const struct plist_node *node)
 #ifdef CONFIG_DEBUG_PLIST
 # define plist_first_entry(head, type, member)          \
     ({                                                  \
-	WARN_ON(plist_head_empty(head));                \
+	warn_on(plist_head_empty(head));                \
 	container_of(plist_first(head), type, member);  \
     })
 #else
@@ -296,7 +296,7 @@ static inline int plist_node_empty(const struct plist_node *node)
 #ifdef CONFIG_DEBUG_PLIST
 # define plist_last_entry(head, type, member)           \
     ({                                                  \
-	WARN_ON(plist_head_empty(head));                \
+	warn_on(plist_head_empty(head));                \
 	container_of(plist_last(head), type, member);   \
     })
 #else

include/pool.h

@@ -1,6 +1,6 @@
 /* pool.h - A simple memory pool manager.
  *
- * Copyright (C) 2021-2022 Bruno Raoult ("br")
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
  * Licensed under the GNU General Public License v3.0 or later.
  * Some rights reserved. See COPYING.
  *
@@ -16,8 +16,9 @@
 
 #include <stdint.h>
 #include <stddef.h>
+
+#include "brlib.h"
 #include "list.h"
-#include "bits.h"
 
 #define POOL_NAME_LENGTH (16)                     /* max name length including trailing \0 */
 

include/struct-group.h

@@ -1,6 +1,6 @@
 /* struct-group.h - mirrored structure macros.
  *
- * Copyright (C) 2021-2022 Bruno Raoult ("br")
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
  * Licensed under the GNU General Public License v3.0 or later.
  * Some rights reserved. See COPYING.
  *
@@ -33,10 +33,10 @@
  * as both having struct attributes appended.
  */
 #define __struct_group(TAG, NAME, ATTRS, MEMBERS...) \
-	union { \
-		struct { MEMBERS } ATTRS; \
-		struct TAG { MEMBERS } ATTRS NAME; \
-	}
+    union {                                          \
+        struct { MEMBERS } ATTRS;                    \
+        struct TAG { MEMBERS } ATTRS NAME;           \
+    }
 
 /**
  * DECLARE_FLEX_ARRAY() - Declare a flexible array usable in a union
@@ -48,11 +48,11 @@
  * struct, it needs to be wrapped in an anonymous struct with at least 1
  * named member, but that member can be empty.
  */
-#define DECLARE_FLEX_ARRAY(TYPE, NAME)	\
-	struct { \
-		struct { } __empty_ ## NAME; \
-		TYPE NAME[]; \
-	}
+#define DECLARE_FLEX_ARRAY(TYPE, NAME)	     \
+    struct {                                 \
+        struct { } __empty_ ## NAME;         \
+        TYPE NAME[];                         \
+    }
 
 /**
  * struct_group() - Wrap a set of declarations in a mirrored struct
@@ -67,7 +67,7 @@
  * struct members.
  */
 #define struct_group(NAME, MEMBERS...)	\
-	__struct_group(/* no tag */, NAME, /* no attrs */, MEMBERS)
+    __struct_group(/* no tag */, NAME, /* no attrs */, MEMBERS)
 
 /**
  * struct_group_attr() - Create a struct_group() with trailing attributes
@@ -83,7 +83,7 @@
  * struct members. Includes structure attributes argument.
  */
 #define struct_group_attr(NAME, ATTRS, MEMBERS...) \
-	__struct_group(/* no tag */, NAME, ATTRS, MEMBERS)
+    __struct_group(/* no tag */, NAME, ATTRS, MEMBERS)
 
 /**
  * struct_group_tagged() - Create a struct_group with a reusable tag
@@ -100,6 +100,6 @@
  * so the specified layout can be reused later.
  */
 #define struct_group_tagged(TAG, NAME, MEMBERS...) \
-	__struct_group(TAG, NAME, /* no attrs */, MEMBERS)
+    __struct_group(TAG, NAME, /* no attrs */, MEMBERS)
 
 #endif  /* _STRUCT_GROUP_H */

scripts/env.sh

@@ -0,0 +1,32 @@
+#!/usr/bin/env bash
+#
+# env.sh - set environment for brchess developer.
+#
+# Copyright (C) 2023 Bruno Raoult ("br")
+# Licensed under the GNU General Public License v3.0 or later.
+# Some rights reserved. See COPYING.
+#
+# You should have received a copy of the GNU General Public License along with this
+# program. If not, see <https://www.gnu.org/licenses/gpl-3.0-standalone.html>.
+#
+# SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
+#
+# USAGE: source env.sh [arg]
+#
+# This file will actually be sourced if it was never sourced in current bash
+# environment.
+
+if [[ ! -v _BRLIB_ENV_ ]]; then
+    export _BRLIB_ENV_=1 BRLIB_ROOT LD_LIBRARY_PATH
+    BRLIB_ROOT=$(realpath -L "$(dirname "${BASH_SOURCE[0]}")/..")
+
+    BRLIB_SCRIPTDIR="$BRLIB_ROOT/scripts"
+    BRLIB_BINDIR="$BRLIB_ROOT/bin"
+    PATH="$PATH:$BRLIB_BINDIR:$BRLIB_SCRIPTDIR"
+
+    BRLIB_LIBDIR="$BRLIB_ROOT/lib"
+    LD_LIBRARY_PATH="${BRLIB_LIBDIR}${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"
+    #printf "R=%s L=%s LD=%s\n" "$BRLIB_ROOT" "$BRLIB_DIR" "$LD_LIBRARY_PATH"
+    unset BRLIB_SCRIPTDIR BRLIB_BINDIR BRLIB_LIBDIR
+    printf "brlib environment complete.\n"
+fi

scripts/submodules-upd.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+
+git submodule update --remote --merge

src/bitops.c

@@ -1,6 +1,6 @@
-/* bits.c - information about bitops implementation.
+/* bitops.c - information about bitops implementation.
  *
- * Copyright (C) 2021-2022 Bruno Raoult ("br")
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
  * Licensed under the GNU General Public License v3.0 or later.
  * Some rights reserved. See COPYING.
  *
@@ -11,16 +11,10 @@
  *
  */
 
-#include "bits.h"
+#include "bitops.h"
 #include "debug.h"
 
-/**
- * bits_implementation - display bitops implementation.
- *
- * For basic bitops (popcount, ctz, etc...), print the implementation
- * (builtin, emulated).
- */
-void bits_implementation(void)
+void print_bitops_impl(void)
 {
     log(0, "bitops implementation: ");
 

src/debug.c

@@ -1,6 +1,7 @@
+
 /* debug.c - debug/log management
  *
- * Copyright (C) 2021-2023 Bruno Raoult ("br")
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
  * Licensed under the GNU General Public License v3.0 or later.
  * Some rights reserved. See COPYING.
  *
@@ -26,10 +27,6 @@ static int level = 0;                             /* output log when < level */
 static int flush = false;                         /* force flush after logs */
 static FILE *stream = NULL;                       /* stream to use */
 
-/**
- * debug_level_set() - set debug level.
- * @_level: debug level (integer).
- */
 void debug_level_set(int _level)
 {
     level = _level;
@@ -38,10 +35,6 @@ void debug_level_set(int _level)
 #   endif
 }
 
-/**
- * debug_level_get() - get debug level.
- * @return: current level debug (integer).
- */
 int debug_level_get(void)
 {
     return level;
@@ -87,14 +80,6 @@ long long debug_timer_elapsed(void)
     return (timer.tv_sec * NANOSEC + timer.tv_nsec) - timer_start;
 }
 
-/**
- * debug() - log function
- * @lev: log level
- * @timestamp: boolean, print timestamp if true
- * @indent: indent level (2 spaces each)
- * @src: source file/func name (or NULL)
- * @line: line number
- */
 void debug(int lev, bool timestamp, int indent, const char *src,
            int line, const char *fmt, ...)
 {

src/list_sort.c

@@ -3,9 +3,9 @@
 /*
  * Taken from linux kernel: lib/list_sort.c
  */
+#include "brlib.h"
 #include "list_sort.h"
 #include "list.h"
-#include "bits.h"
 #include "likely.h"
 
 /*

src/pjwhash.c

@@ -1,6 +1,6 @@
 /* pjwhash.c - PJW hash function.
  *
- * Copyright (C) 2021-2022 Bruno Raoult ("br")
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
  * Licensed under the GNU General Public License v3.0 or later.
  * Some rights reserved. See COPYING.
  *
@@ -13,8 +13,5 @@
 
 #define _pjw_inline extern
 
-//#include "bits.h"
-//extern unsigned int  pjwhash (const void* key, uint length);
-
 #include "pjwhash.h"
 #include "pjwhash-inline.h"

src/plist.c

@@ -32,7 +32,7 @@ static struct plist_head test_head;
 static void plist_check_prev_next(struct list_head *t, struct list_head *p,
 				  struct list_head *n)
 {
-    WARN(n->prev != p || p->next != n,
+    warn(n->prev != p || p->next != n,
          "top: %p, n: %p, p: %p\n"
          "prev: %p, n: %p, p: %p\n"
          "next: %p, n: %p, p: %p\n",
@@ -76,8 +76,8 @@ void plist_add(struct plist_node *node, struct plist_head *head)
     struct list_head *node_next = &head->node_list;
 
     plist_check_head(head);
-    WARN_ON(!plist_node_empty(node));
-    WARN_ON(!list_empty(&node->prio_list));
+    warn_on(!plist_node_empty(node));
+    warn_on(!list_empty(&node->prio_list));
 
     if (plist_head_empty(head))
         goto ins_node;
@@ -148,8 +148,8 @@ void plist_requeue(struct plist_node *node, struct plist_head *head)
     struct list_head *node_next = &head->node_list;
 
     plist_check_head(head);
-    BUG_ON(plist_head_empty(head));
-    BUG_ON(plist_node_empty(node));
+    bug_on(plist_head_empty(head));
+    bug_on(plist_node_empty(node));
 
     if (node == plist_last(head))
         return;

src/pool.c

@@ -1,6 +1,6 @@
 /* pool.c - A simple pool manager.
  *
- * Copyright (C) 2021-2022 Bruno Raoult ("br")
+ * Copyright (C) 2021-2024 Bruno Raoult ("br")
  * Licensed under the GNU General Public License v3.0 or later.
  * Some rights reserved. See COPYING.
  *
@@ -17,10 +17,10 @@
 #include <stdlib.h>
 #include <errno.h>
 
+#include "brlib.h"
 #include "list.h"
 #include "pool.h"
 #include "debug.h"
-#include "bits.h"
 
 void pool_stats(pool_t *pool)
 {

test/bitops-test.c

@@ -0,0 +1,364 @@
+/* bits.c - bitops testing.
+ *
+ * Copyright (C) 2024 Bruno Raoult ("br")
+ * Licensed under the GNU General Public License v3.0 or later.
+ * Some rights reserved. See COPYING.
+ *
+ * You should have received a copy of the GNU General Public License along with this
+ * program. If not, see <https://www.gnu.org/licenses/gpl-3.0-standalone.html>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
+ *
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "brlib.h"
+#include "bitops.h"
+#include "cutest/CuTest.h"
+
+static const struct test32_1 {
+    u32 t32;                                      /* input */
+    u32 bswap;
+    int popc;
+    int ctz;
+    int clz;
+    int ffs;
+    int ffz;
+    int fls;
+    int ilog2;
+    struct {
+        int size;
+        uchar bfe[32];
+    };
+} test32_1[] = {
+    { 0x00000000, 0x00000000, 0, 32, 32,  0, 1,  0,  0, /* sometimes undefined */
+      { 0, { 0 } } },
+    { 0xffffffff, 0xffffffff, 32,   0,  0,  1, 0, 32, 31,
+      { 32, { 0,  1,  2,  3,  4,  5,  6,  7, 8,  9, 10, 11, 12, 13, 14, 15,
+            16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31 } } },
+    { 0x00000001, 0x01000000,  1,   0, 31,  1, 2,  1,  0,
+      { 1, { 0 } } },
+    { 0x80000000, 0x00000080,  1,  31,  0, 32, 1, 32, 31,
+      { 1, { 31 } } },
+    { 0x71800718, 0x18078071, 10,   3,  1,  4, 1, 31, 30,
+      /* 0111 0001 1000 0000 0000 0111 0001 1000 */
+      { 10, { 3, 4, 8, 9, 10, 23, 24, 28, 29, 30 } } },
+    { 0x07eeeef7, 0xf7eeee07, 22,   0,  5,  1, 4, 27, 26,
+      /* 0000 0111 1110 1110 1110 1110 0111 1111*/
+      { 22, { 0, 1, 2, 4, 5, 6, 7, 9, 10, 11, 13,
+            14, 15, 17, 18, 19, 21, 22, 23, 24, 25, 26 } } },
+};
+
+static const struct test64_1 {
+    u64 t64;                                      /* input */
+    u64 bswap;
+    int popc;                                     /* some values may be undefined */
+    int ctz;
+    int clz;
+    int ffs;
+    int ffz;
+    int fls;
+    int ilog2;
+    struct {
+        int size;
+        uchar bfe[64];
+    };
+} test64_1[] = {
+    { 0x0000000000000000, 0x0000000000000000,  0, 64, 64,  0, 1,  0,  0,
+      { 0, { 0 } } },
+    { 0xffffffffffffffff, 0xffffffffffffffff, 64,  0,  0,  1, 0, 64, 63,
+      { 64, { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15,
+            16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31,
+            32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47,
+            48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63 } } },
+    { 0x0000000100000001, 0x0100000001000000,  2,  0, 31,  1, 2, 33, 32,
+      { 2, { 0, 32 } } },
+    { 0x8000000000000000, 0x0000000000000080,  1, 63,  0, 64, 1, 64, 63,
+      { 1, { 63 } } },
+    { 0x7180071871800718, 0x1807807118078071, 20,  3,  1,  4, 1, 63, 62,
+      /* 2 x 0111 0001 1000 0000 0000 0111 0001 1000 */
+      { 20, { 3, 4, 8, 9, 10, 23, 24, 28, 29, 30,
+            35, 36, 40, 41, 42, 55, 56, 60, 61, 62 } } },
+    { 0x07eeeef707eeeef7, 0xf7eeee07f7eeee07, 44,  0,  5,  1, 4, 59, 58 ,
+      /* 2 x 0000 0111 1110 1110 1110 1110 0111 1111*/
+      { 44, { 0, 1, 2, 4, 5, 6, 7, 9, 10, 11, 13,
+            14, 15, 17, 18, 19, 21, 22, 23, 24, 25, 26,
+            32, 33, 34, 36, 37, 38, 39, 41, 42, 43, 45,
+            46, 47, 49, 50, 51, 53, 54, 55, 56, 57, 58 } } },
+};
+
+static void cutest_popcount(CuTest *tc)
+{
+    for (uint i = 0; i < ARRAY_SIZE(test32_1); ++i) {
+        int res = popcount32(test32_1[i].t32);
+        CuAssertIntEquals(tc, test32_1[i].popc, res);
+    }
+    for (uint i = 0; i < ARRAY_SIZE(test64_1); ++i) {
+        int res = popcount64(test64_1[i].t64);
+        CuAssertIntEquals(tc, test64_1[i].popc, res);
+    }
+}
+
+static void cutest_ctz(CuTest *tc)
+{
+    for (uint i = 0; i < ARRAY_SIZE(test32_1); ++i) {
+        int res = ctz32(test32_1[i].t32);
+        CuAssertIntEquals(tc, test32_1[i].ctz, res);
+    }
+    for (uint i = 0; i < ARRAY_SIZE(test64_1); ++i) {
+        int res = ctz64(test64_1[i].t64);
+        //printf("t=%#llx r=%d e=%d\n", test64_1[i].t64, res, test64_1[i].ctz);
+        CuAssertIntEquals(tc, test64_1[i].ctz, res);
+    }
+}
+
+static void cutest_clz(CuTest *tc)
+{
+    for (uint i = 0; i < ARRAY_SIZE(test32_1); ++i) {
+        int res = clz32(test32_1[i].t32);
+        //printf("clz t=%#x r=%d e=%d\n", test32_1[i].t32, res, test32_1[i].clz);
+        CuAssertIntEquals(tc, test32_1[i].clz, res);
+    }
+    for (uint i = 0; i < ARRAY_SIZE(test64_1); ++i) {
+        int res = clz64(test64_1[i].t64);
+        //printf("clz t=%#llx r=%d e=%d\n", test64_1[i].t64, res, test64_1[i].clz);
+        CuAssertIntEquals(tc, test64_1[i].clz, res);
+    }
+}
+
+static void cutest_ffs(CuTest *tc)
+{
+    for (uint i = 0; i < ARRAY_SIZE(test32_1); ++i) {
+        int res = ffs32(test32_1[i].t32);
+        CuAssertIntEquals(tc, test32_1[i].ffs, res);
+    }
+    for (uint i = 0; i < ARRAY_SIZE(test64_1); ++i) {
+        int res = ffs64(test64_1[i].t64);
+        //printf("ffs64 t=%#llx r=%d e=%d\n", test64_1[i].t64, res, test64_1[i].ffs);
+        CuAssertIntEquals(tc, test64_1[i].ffs, res);
+    }
+}
+
+static void cutest_ffz(CuTest *tc)
+{
+    for (uint i = 0; i < ARRAY_SIZE(test32_1); ++i) {
+        int res = ffz32(test32_1[i].t32);
+        //printf("ffz32 t=%#x r=%d e=%d\n", test32_1[i].t32, res, test32_1[i].ffz);
+        CuAssertIntEquals(tc, test32_1[i].ffz, res);
+    }
+    for (uint i = 0; i < ARRAY_SIZE(test64_1); ++i) {
+        int res = ffz64(test64_1[i].t64);
+        //printf("ffz64 t=%#llx r=%d e=%d\n", test64_1[i].t64, res, test64_1[i].ffz);
+        CuAssertIntEquals(tc, test64_1[i].ffz, res);
+    }
+}
+
+static void cutest_fls(CuTest *tc)
+{
+    for (uint i = 0; i < ARRAY_SIZE(test32_1); ++i) {
+        int res = fls32(test32_1[i].t32);
+        //printf("fls32 t=%#x r=%d e=%d\n", test32_1[i].t32, res, test32_1[i].fls);
+        CuAssertIntEquals(tc, test32_1[i].fls, res);
+    }
+    for (uint i = 0; i < ARRAY_SIZE(test64_1); ++i) {
+        int res = fls64(test64_1[i].t64);
+        //printf("fls64 t=%#llx r=%d e=%d\n", test64_1[i].t64, res, test64_1[i].fls);
+        CuAssertIntEquals(tc, test64_1[i].fls, res);
+    }
+}
+
+static void cutest_bswap(CuTest *tc)
+{
+    for (uint i = 0; i < ARRAY_SIZE(test32_1); ++i) {
+        int res = bswap32(test32_1[i].t32);
+        //printf("fls32 t=%#x r=%d e=%d\n", test32_1[i].t32, res, test32_1[i].fls);
+        CuAssertIntEquals(tc, test32_1[i].bswap, res);
+    }
+    for (uint i = 0; i < ARRAY_SIZE(test64_1); ++i) {
+        int res = bswap64(test64_1[i].t64);
+        //printf("fls64 t=%#llx r=%d e=%d\n", test64_1[i].t64, res, test64_1[i].fls);
+        CuAssertIntEquals(tc, test64_1[i].bswap, res);
+    }
+}
+
+static void cutest_ilog(CuTest *tc)
+{
+    for (uint i = 0; i < ARRAY_SIZE(test32_1); ++i) {
+        if (!test32_1[i].t32) {
+            //printf("ilog2_32 t=%#x skipped\n", test32_1[i].t32);
+            continue;
+        }
+        int res = ilog2_32(test32_1[i].t32);
+        //printf("ilog2_32_n t=%#x r=%d e=%d\n", test32_1[i].t32,
+        //       res, test32_1[i].ilog2);
+        CuAssertIntEquals(tc, test32_1[i].ilog2, res);
+    }
+    for (uint i = 0; i < ARRAY_SIZE(test64_1); ++i) {
+        if (!test64_1[i].t64) {
+            //printf("ilog2_32 t=%#llx skipped\n", test64_1[i].t64);
+            continue;
+        }
+        int res = ilog2_64(test64_1[i].t64);
+        //printf("ilog2_64_n t=%#llx r=%d e=%d\n", test64_1[i].t64,
+        //       res, test64_1[i].ilog2);
+        CuAssertIntEquals(tc, test64_1[i].ilog2, res);
+    }
+}
+
+static void cutest_bfe(CuTest *tc)
+{
+    char s[64];
+
+    for (uint i = 0; i < ARRAY_SIZE(test32_1); ++i) {
+        u32 tmp;
+        int cur, nb = 0;
+        char bfe_ffs[32];
+
+        /* create bit_for_each32_ffs values */
+        for (int j = 0; j < test32_1[i].size; ++j)
+            bfe_ffs[j] = test32_1[i].bfe[j] + 1;
+
+        bit_for_each32(cur, tmp, test32_1[i].t32) {
+            s[nb++] = cur;
+        }
+        CuAssertIntEquals(tc, test32_1[i].size, nb);
+        CuAssertMemEquals(tc, test32_1[i].bfe, s, test32_1[i].size);
+        nb = 0;
+        bit_for_each32_ffs(cur, tmp, test32_1[i].t32) {
+            s[nb++] = cur;
+        }
+        CuAssertMemEquals(tc, bfe_ffs, s, test32_1[i].size);
+    }
+
+    for (uint i = 0; i < ARRAY_SIZE(test64_1); ++i) {
+        u64 tmp;
+        int cur, nb = 0;
+        char bfe_ffs[64];
+
+        /* create bit_for_each64_ffs values */
+        for (int j = 0; j < test64_1[i].size; ++j)
+            bfe_ffs[j] = test64_1[i].bfe[j] + 1;
+
+        bit_for_each64(cur, tmp, test64_1[i].t64) {
+            s[nb++] = cur;
+        }
+        //printf("\n64 nb=%d size=%d\n", nb, test64_1[i].size);
+        CuAssertIntEquals(tc, test64_1[i].size, nb);
+        CuAssertMemEquals(tc, test64_1[i].bfe, s, test64_1[i].size);
+        nb = 0;
+        bit_for_each64_ffs(cur, tmp, test64_1[i].t64) {
+            s[nb++] = cur;
+        }
+        CuAssertMemEquals(tc, bfe_ffs, s, test64_1[i].size);
+    }
+}
+
+struct test32_2 {
+    u32 t32;                                      /* input */
+    u32 arg;
+    u32 rol;
+    u32 ror;
+    struct {
+        int size;
+        uchar bfe[32];
+    };
+} test32_2[] = {
+    { 0x00000000, 0,  0, 0,
+      {  0, { 0 }  } },
+    { 0x00000000, 1,  0, 0,
+      {  0, { 0 }  } },
+    { 0x10000001, 2,  0x40000004, 0x44000000,
+      {  2, { 0, 28 } } },
+    { 0x80000008, 3,  0x00000044, 0x10000001,
+      {  2, { 3, 31 } } },
+    { 0x71800718, 8,  0x80071871, 0x18718007,
+      { 10, { 3, 4, 8, 9, 10, 23, 24, 28, 29, 30 } } },
+    { 0x07eeeef7, 4,  0x7eeeef70, 0x707eeeef,
+      { 22, { 0, 1, 2, 4, 5, 6, 7, 9, 10,
+            11, 13, 14, 15, 17, 18, 19,
+            21, 22, 23, 24, 25, 26 } } },
+};
+
+struct test64_2 {
+    u64 t64;                                      /* input */
+    u32 arg;
+    u64 rol;
+    u64 ror;
+} test64_2[] = {
+    { 0x0000000000000000, 0,  0, 0 },
+    { 0x0000000000000000, 1,  0, 0 },
+    { 0x1000000110000001, 2,  0x4000000440000004, 0x4400000044000000 },
+    { 0x8000000880000008, 3,  0x0000004400000044, 0x1000000110000001 },
+    { 0x7180071871800718, 8,  0x8007187180071871, 0x1871800718718007 },
+    { 0x07eeeef707eeeef7, 4,  0x7eeeef707eeeef70, 0x707eeeef707eeeef }
+};
+
+static void cutest_rol(CuTest *tc)
+{
+    for (uint i = 0; i < ARRAY_SIZE(test32_2); ++i) {
+        u32 res = rol32(test32_2[i].t32, test32_2[i].arg);
+        //printf("rol32 t=%#x a=%u r=%#08x e=%#08x\n", test32_2[i].t32,
+        //       test32_2[i].arg, res, test32_2[i].rol);
+        CuAssertU32Equals(tc, test32_2[i].rol, res);
+    }
+    for (uint i = 0; i < ARRAY_SIZE(test64_2); ++i) {
+        u64 res = rol64(test64_2[i].t64, test64_2[i].arg);
+        //printf("rol64 t=%#llx a=%u r=%#08llx e=%#08llx\n", test64_2[i].t64,
+        //       test64_2[i].arg, res, test64_2[i].rol);
+        CuAssertU64Equals(tc, test64_2[i].rol, res);
+    }
+}
+
+static void cutest_ror(CuTest *tc)
+{
+    for (uint i = 0; i < ARRAY_SIZE(test32_2); ++i) {
+        u32 res = ror32(test32_2[i].t32, test32_2[i].arg);
+        //printf("ror32 t=%#x a=%u r=%#08x e=%#08x\n", test32_2[i].t32,
+        //       test32_2[i].arg, res, test32_2[i].ror);
+        CuAssertU32Equals(tc, test32_2[i].ror, res);
+    }
+    for (uint i = 0; i < ARRAY_SIZE(test64_2); ++i) {
+        u64 res = ror64(test64_2[i].t64, test64_2[i].arg);
+        //printf("ror64 t=%#0llx a=%u r=%#08llx e=%#08llx\n", test64_2[i].t64,
+        //       test64_2[i].arg, res, test64_2[i].ror);
+        CuAssertU64Equals(tc, test64_2[i].ror, res);
+    }
+}
+
+static CuSuite *bitops_GetSuite()
+{
+    CuSuite* suite = CuSuiteNew();
+    SUITE_ADD_TEST(suite, cutest_popcount);
+    SUITE_ADD_TEST(suite, cutest_ctz);
+    SUITE_ADD_TEST(suite, cutest_clz);
+    SUITE_ADD_TEST(suite, cutest_ffs);
+    SUITE_ADD_TEST(suite, cutest_ffz);
+    SUITE_ADD_TEST(suite, cutest_fls);
+    SUITE_ADD_TEST(suite, cutest_ilog);
+    SUITE_ADD_TEST(suite, cutest_bfe);
+    SUITE_ADD_TEST(suite, cutest_bswap);
+
+    SUITE_ADD_TEST(suite, cutest_rol);
+    SUITE_ADD_TEST(suite, cutest_ror);
+    return suite;
+}
+
+static void RunAllTests(void)
+{
+    CuString *output = CuStringNew();
+    CuSuite* suite = CuSuiteNew();
+    CuSuiteAddSuite(suite, bitops_GetSuite());
+
+    CuSuiteRun(suite);
+    CuSuiteSummary(suite, output);
+    CuSuiteDetails(suite, output);
+    printf("%s\n", output->buffer);
+}
+
+int main()
+{
+    RunAllTests();
+    exit(0);
+}

test/pool-test.c

@@ -1,6 +1,9 @@
 #include <stdio.h>
-#include "bits.h"
+#include <stdlib.h>
+
+#include "brlib.h"
 #include "pool.h"
+#include "debug.h"
 
 struct d {
     u16 data1;
@@ -19,7 +22,7 @@ int main(int ac, char**av)
     char ccur='z';
     struct d *elt;
 
-    debug_init(3);
+    debug_init(3, stderr, true);
     log_f(1, "%s: sizeof(d)=%lu sizeof(*d)=%lu off=%lu\n", *av, sizeof(elt),
           sizeof(*elt), offsetof(struct d, list));